fix: add validation for robot node in URDF parsing#338
Open
MatrixNeoKozak wants to merge 1 commit into
Open
Conversation
Owner
|
Do you have an example of when you're running into this issue? Generally we have to expect that the user is providing well-formed files. Otherwise short of checking every single node, attribute, and value it's not possible to catch every failure case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check to verify that a node exists when parsing a URDF file. This prevents runtime errors when attempting to access properties on a non-existent element in malformed or empty files. A corresponding test case has been added to verify this behavior.